[test] Test event emit when user withdraw fund's balance #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @DiegoB1911 could you please merge your code with the latest changes in dev and fix the conflicts ? |
|
Sure, I'm working on it |
EmmanuelAR
requested changes
Oct 31, 2024
contracts/tests/test_fund.cairo
Outdated
| // approve | ||
| cheat_caller_address(token_address, FUND_MANAGER(), CheatSpan::TargetCalls(1)); | ||
| token_dispatcher.approve(contract_address, goal); | ||
|
|
There was a problem hiding this comment.
I know that you create the setup_donation method to avoid to repeat code but in this case please leave it ass the original
|
Exc work Diego @DiegoB1911 some changes tkssss |
EmmanuelAR
requested changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Changes description
This PR introduces a test to verify that the correct event is emitted when the withdraw function is called
Current output
Time spent breakdown
Give a breakdown on the time you used to solve the issue you are closing.
Comments
Any other details you might want to share.